Add safe uninitialized GEMM overwrite paths - #196
Merged
Conversation
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaybeUninit<T>entry points for einsum2, dot-general, and raw batched GEMM.strided-opteinsumintermediate pooling to overwrite-only storage while preserving owned-input paths.cblas-injectto0.1.2for the exact-zero beta contract.Faer boundary
Faer 0.24.4 does not expose a typed API that permits a
MatMut<T>overwrite overMaybeUninit<T>. The Faer-only public uninitialized entry points therefore returnEinsumError::Unsupportedand retain the initialized compatibility path. This PR does not use an unsafe cast, earlyassume_init, or zero-fill workaround. The remaining Faer implementation is tracked in strided-rs#195.This is the safe backend portion of strided-rs#188; it intentionally does not claim that the Faer portion is complete.
Verification
cargo fmt --all -- --checkgit diff --checkcargo test --workspacewithCARGO_BUILD_JOBS=4and linker threads limited to 1 to avoid the local Rust 1.97 linker resource failurestrided-einsum2feature matrix: no-default, Faer, BLAS, and blas-injectstrided-opteinsumfeature matrix: no-default, Faer, BLAS, and blas-inject